Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add setJoinSubsetType to inject joinSubsetType to BeamSqlSeekableTable #28477

Merged
merged 5 commits into from
Sep 20, 2023
Merged

add setJoinSubsetType to inject joinSubsetType to BeamSqlSeekableTable #28477

merged 5 commits into from
Sep 20, 2023

Conversation

gabrywu
Copy link
Member

@gabrywu gabrywu commented Sep 15, 2023

closing #28283

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2023 •
edited
Loading

Test Results

  7 files   -   41    7 suites   - 41   52m 23s ⏱️ - 1d 3h 55m 46s
  7 tests  - 285    7 ✔️  - 282  0 💤  - 3  0 ❌ ±0 
13 runs   - 279  13 ✔️  - 276  0 💤  - 3  0 ❌ ±0 

Results for commit c08b522. ± Comparison against base commit 5df59a9.

This pull request removes 292 and adds 7 tests. Note that renamed tests count towards both. 
org.apache.beam.runners.dataflow.DataflowRunnerTest ‑ testBatchGroupIntoBatchesOverrideBytes
org.apache.beam.runners.dataflow.DataflowRunnerTest ‑ testBatchGroupIntoBatchesOverrideCount
org.apache.beam.sdk.PipelineTest ‑ testIdentityTransform
org.apache.beam.sdk.PipelineTest ‑ testMultipleApply
org.apache.beam.sdk.PipelineTest ‑ testTupleInjectionTransform
org.apache.beam.sdk.PipelineTest ‑ testTupleProjectionTransform
org.apache.beam.sdk.io.CountingSourceTest ‑ testBoundedSourceSplits
org.apache.beam.sdk.io.CountingSourceTest ‑ testUnboundedSourceSplits
org.apache.beam.sdk.schemas.AvroSchemaTest ‑ testAvroPipelineGroupBy
org.apache.beam.sdk.testing.PAssertTest ‑ testAssertionSiteIsCapturedWithMessage
…

org.apache.beam.examples.WindowedWordCountIT ‑ testWindowedWordCountInBatchDynamicSharding
org.apache.beam.examples.WindowedWordCountIT ‑ testWindowedWordCountInBatchStaticSharding
org.apache.beam.examples.WindowedWordCountIT ‑ testWindowedWordCountInStreamingStaticSharding
org.apache.beam.examples.WordCountIT ‑ testE2EWordCount
org.apache.beam.sdk.testutils.jvmverification.JvmVerification ‑ verifyCodeIsCompiledWithJava8
org.apache.beam.sdk.testutils.jvmverification.JvmVerification ‑ verifyRunningJVMVersionIs17
org.apache.beam.sdk.testutils.jvmverification.JvmVerification ‑ verifyTestCodeIsCompiledWithJava17

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@gabrywu
1. delete setJoinSubsetType
c08b522 
2. move joinSubsetType to setUp method
@Abacn Abacn merged commit 93de970 into apache:master Sep 20, 2023
22 checks passed
@gabrywu
Copy link
Member Author

gabrywu commented Sep 21, 2023

@Abacn thanks for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abacn Abacn Abacn approved these changes

Assignees
No one assigned
Labels
extensions java Next Action: Reviewers sql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrywu @Abacn